Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Chart Testing GitHub Action, to Lint and Install Chart on PR #7

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

braveokafor
Copy link
Contributor

Summary:

  • Added Chart Documentation with Helm Docs.
  • Minor Cleanup for Linting (to conform with best practices).
  • Added Chart linting action with chart-testing.
  • Added Chart testing (installation) action with chart-testing. This should help with this issue Tests #6.
  • Fixed bug in templates/tests/test-connection.yaml. This was failing chart installation tests, StackOverflow issue.

Please Review.

Copy link
Contributor

@sgirones sgirones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution @braveokafor!

@sgirones sgirones merged commit 6f844b7 into surrealdb:main Mar 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants